Discussion:
[Cython] Variable shadows type name in posix/time.pxd
Joel Nothman
2014-09-14 11:06:03 UTC
Permalink
a struct
<https://github.com/cython/cython/blob/master/Cython/Includes/posix/time.pxd#L48>
and a double
<https://github.com/cython/cython/blob/master/Cython/Includes/posix/time.pxd#L105>
are defined with the name 'timezone' in posix/time.pxd. Hence

from posix.time cimport timeval, timezone, gettimeofday
cdef timeval tv
cdef timezone tz
gettimeofday(&tv, &tz)

fails with 'timezone' is not a type identifier

It would be nice if there were a test for duplicate names in pxd files.

Thanks for the awesome tool, Joel
Stefan Behnel
2014-09-23 17:17:48 UTC
Permalink
Post by Joel Nothman
a struct
<https://github.com/cython/cython/blob/master/Cython/Includes/posix/time.pxd#L48>
and a double
<https://github.com/cython/cython/blob/master/Cython/Includes/posix/time.pxd#L105>
are defined with the name 'timezone' in posix/time.pxd. Hence
from posix.time cimport timeval, timezone, gettimeofday
cdef timeval tv
cdef timezone tz
gettimeofday(&tv, &tz)
fails with 'timezone' is not a type identifier
Thanks.

https://github.com/cython/cython/commit/4562c6b5501ec17b2e11f04be10b5d8c3d728ba3
Post by Joel Nothman
It would be nice if there were a test for duplicate names in pxd files.
Agreed.

http://trac.cython.org/cython_trac/ticket/835
Post by Joel Nothman
Thanks for the awesome tool, Joel
:)

Stefan

Loading...